Re: Header checking failures on LLVM-less machines - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Header checking failures on LLVM-less machines
Date
Msg-id 22407.1548731972@sss.pgh.pa.us
Whole thread Raw
In response to Re: Header checking failures on LLVM-less machines  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> I don't think we are actually contradicting each other. The aim of that
> error was to prevent pieces of code that aren't conditional on
> --with-llvm from including llvmjit.h.  I was, for a moment and wrongly,
> thinking that we could style the header in a way that'd make it both for
> safe for cpluspluscheck and still error in that case, but that was a
> brainfart.  But even leaving that brainfart aside, I'm not arguing
> against adding those include guards, so ...?

Works for me now.  Thanks for fixing.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Kyotaro HORIGUCHI
Date:
Subject: Re: pg_stat_ssl additions
Next
From: Andres Freund
Date:
Subject: Re: Why are we PageInit'ing buffers in RelationAddExtraBlocks()?