Re: Increase of buffers usage count by bgwriter - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Increase of buffers usage count by bgwriter
Date
Msg-id 22389.1130432952@sss.pgh.pa.us
Whole thread Raw
In response to Re: Increase of buffers usage count by bgwriter  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
I wrote:
> ITAGAKI Takahiro <itagaki.takahiro@lab.ntt.co.jp> writes:
>> I found that bgwriter increments usage count of buffers when it writes
>> the buffers. I feel this behavior is strange, because the behavior of
>> bgwriter will affect buffer management strategy.

> I think it might be sufficient to not increment usage_count when
> UnpinBuffer's "trashOK" parameter is false --- that's what
> SyncOneBuffer passes, so it'd fix the issue for bgwriter activity,
> and arguably all the other call sites that pass false also don't
> want the count to increment.

I've committed a change along this line.  Thanks for the suggestion!
        regards, tom lane


pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: Test settings in postgresql.conf.sample in beta4
Next
From: Tom Lane
Date:
Subject: Re: Ideas for easier debugging of backend problems