Re: [PATCH] postgresql.conf.sample comment alignment. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] postgresql.conf.sample comment alignment.
Date
Msg-id 2235495.1659398604@sss.pgh.pa.us
Whole thread Raw
In response to [PATCH] postgresql.conf.sample comment alignment.  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: [PATCH] postgresql.conf.sample comment alignment.
Re: [PATCH] postgresql.conf.sample comment alignment.
List pgsql-hackers
Peter Smith <smithpb2250@gmail.com> writes:
> This patch tweaks a some tabbing and replaces some spaces with tabs to
> improve slightly the comment alignment in file
> 'postgresql.conf.sample'

Hmm ... the parts you want to change generally look OK to me.
I wonder if you are looking at it with tab stops set to 4 spaces
rather than 8 spaces?

While 4 spaces is our convention for C code, postgresql.conf
is going to be edited by end users who almost certainly have their
editors set up for 8 spaces, so it's going to look funny to them
if the comments are aligned on the assumption of 4 spaces.

One idea for avoiding confusion is to legislate that we won't
use tabs at all in this file (which we could enforce via
.gitattributes, I think).  But that might just be making things
equally inconvenient for everybody.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Table AM and DROP TABLE [ Was: Table AM and DDLs]
Next
From: Thomas Munro
Date:
Subject: Re: Cleaning up historical portability baggage