That dump-comments-on-composite-type-columns patch... - Mailing list pgsql-patches

From Tom Lane
Subject That dump-comments-on-composite-type-columns patch...
Date
Msg-id 22334.1091816865@sss.pgh.pa.us
Whole thread Raw
Responses Re: That dump-comments-on-composite-type-columns patch...
List pgsql-patches
... doesn't work.

$ pg_dump regression >zzz.out
pg_dump: SQL command failed
pg_dump: Error message from server: ERROR:  "complex" is a composite type
pg_dump: The command was: COPY public.complex (r, i) TO stdout;
$

I suspect it had more subtle problems too, because dumpTableComments
would have attached the comments to the dumpid associated with the
TableInfo entry, which isn't the object that will get dumped.  So it
seems moderately likely that there would have been a potential for
misordering of the output.

I think it's probably a fundamentally bad idea to be putting composite
types into pg_dump's TableInfo array, because they just really aren't
tables at all.  If you want to try again, I'd suggest writing a variant
of dumpTableComment that takes a TypeInfo and the attribute-names query
data obtained by dumpCompositeType.

            regards, tom lane

pgsql-patches by date:

Previous
From: David Fetter
Date:
Subject: Intro patch
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] UNICODE characters above 0x10000