On 14.11.25 12:00, Álvaro Herrera wrote:
> On 2025-Nov-12, Peter Eisentraut wrote:
>
>> Well, that's the one, but the code actually looks like this now:
>>
>> while ((i = bms_next_member(atts, i)) >= 0)
>> {
>> attcnt++;
>> if (attcnt > 1)
>> appendStringInfoString(&attsbuf, _(", "));
>>
>> appendStringInfo(&attsbuf, _("\"%s\""), remoterel->attnames[i]);
>> }
>>
>> The catalog entries you are showing appear to be from pre-PG18.
>
> Ah, right.
>
>> There are also similar instances in ExecBuildSlotValueDescription() that are
>> not marked up for gettext but perhaps should be. There might be others, and
>> I would expect more like this to appear over time, as people like to add
>> more detail like this to diagnostics messages.
>
> Sure.
>
>> Do you have a suggestion what kind of comment to attach there?
>
> I would say "This is a separator in a list of entity names." We don't
> need to be specific as to what kind of entity it is, I think.
Ok, committed that way.
