Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well
Date
Msg-id 22230.1542148037@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well  (Andres Freund <andres@anarazel.de>)
Responses Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2018-11-13 11:40:05 +0100, Christoph Berg wrote:
>> While working on making extension modules built reproducibly, I
>> noticed that extra flags passed via COPT (notably -ffile-prefix-map)
>> do not get added to CXXFLAGS.

> PROFILE I can see, but COPT I'm less sure. The name suggests it's about
> C not C++. How about adding CXXOPT?

> Secondary question:  Why aren't you using CFLAGS/CXXFLAGS for this?

COPT (and PROFILE) are handy for injecting additional flags manually;
they're even documented for that (cf installation.sgml, around line
1550).

I agree that CXXOPT would be a better idea than COPT for this.
Not sure about PROFILE.  But we could inject the latter into both
flag sets and then document that if that's not what you want, use COPT.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Jordan Deitch
Date:
Subject: add the source of param misconfigurations to error messages
Next
From: Tom Lane
Date:
Subject: Re: add the source of param misconfigurations to error messages