Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH 1/5] Centralize Assert* macros into c.h so its common between backend/frontend - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH 1/5] Centralize Assert* macros into c.h so its common between backend/frontend
Date
Msg-id 22148.1357673712@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH 1/5] Centralize Assert* macros into c.h so its common between backend/frontend  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: [PATCH 1/5] Centralize Assert* macros into c.h so its common between backend/frontend
List pgsql-hackers
Tree view 
Andres Freund <andres@2ndquadrant.com> writes:
> On 2013-01-08 14:25:06 -0500, Tom Lane wrote:
>> This patch seems unnecessary given that we already put a version of Assert()
>> into postgres_fe.h.

> The problem is that some (including existing) pieces of code need to
> include postgres.h itself, those can't easily include postgres_fe.h as
> well without getting into problems with redefinitions.

There is no place, anywhere, that should be including both.  So I don't
see the problem.
        regards, tom lane

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [PATCH 1/5] Centralize Assert* macros into c.h so its common between backend/frontend
Next
From: Andres Freund
Date:
Subject: Re: [PATCH 2/5] Make relpathbackend return a statically result instead of palloc()'ing it