Re: Dead code in ps_status.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Dead code in ps_status.c
Date
Msg-id 2203806.1676525640@sss.pgh.pa.us
Whole thread Raw
In response to Dead code in ps_status.c  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: Dead code in ps_status.c
List pgsql-hackers
Thomas Munro <thomas.munro@gmail.com> writes:
> Therefore I think it is safe to drop the PS_USE_PS_STRING and
> PS_USE_CHANGE_ARGV code branches, remove a bunch of outdated comments
> and macro tests, and prune the defunct configure/meson probe.

Seems reasonable.  Patch passes an eyeball check.

> I guess (defined(sun) && !defined(BSD)) || defined(__svr5__) could be
> changed to just defined(sun) (surely there are no other living
> SysV-derived systems, and I think non-BSD Sun probably meant "Solaris
> but not SunOS"), but I don't know so I didn't touch that.

Hm, is "defined(sun)" true on any live systems at all?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: DDL result is lost by CREATE DATABASE with WAL_LOG strategy
Next
From: Amul Sul
Date:
Subject: remove duplicate comment.