AW: [HACKERS] freefuncs.c is never called from anywhere!? - Mailing list pgsql-hackers

From Zeugswetter Andreas SB
Subject AW: [HACKERS] freefuncs.c is never called from anywhere!?
Date
Msg-id 219F68D65015D011A8E000006F8590C603FDC237@sdexcsrv1.f000.d0188.sd.spardat.at
Whole thread Raw
Responses Re: AW: [HACKERS] freefuncs.c is never called from anywhere!?
List pgsql-hackers
> > (In the same spirit it would also be nice to tag NOT_USED 
> sections with a
> > version number, so it could be yanked two or three releases past.)
> 
> Why not just yank it period?  'cvs diff' will show what was 
> yanked, and
> the log message could say just 'yanked NOT_USED code from 
> source tree'...

Once GetAttributeBy[Num|Name] was yanked, because it was not referenced 
inside the code. It is heavily used in extensions though.

For me it was relatively easy to find the problem, because it was ifdef'd
NOT_USED.
I am not sure if I had found it that easily, if the "old" code would have
only been in cvs.

Andreas


pgsql-hackers by date:

Previous
From: Michael Meskes
Date:
Subject: Re: [HACKERS] PCLabs Survey, Part VII: Embedded Database / Branch Office Support
Next
From: Horák Daniel
Date:
Subject: RE: [HACKERS] PCLabs Survey, Part VII: Embedded Database / Branch Office Support