Re: Possible memory corruption (src/timezone/zic.c b/src/timezone/zic.c) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Possible memory corruption (src/timezone/zic.c b/src/timezone/zic.c)
Date
Msg-id 2199808.1621032731@sss.pgh.pa.us
Whole thread Raw
In response to Re: Possible memory corruption (src/timezone/zic.c b/src/timezone/zic.c)  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Possible memory corruption (src/timezone/zic.c b/src/timezone/zic.c)  (Ranier Vilela <ranier.vf@gmail.com>)
List pgsql-hackers
I wrote:
> So the question for us is whether it's worth trying to make pgreadlink
> conform to the letter of the POSIX spec in this detail.  TBH, I can't
> get excited about that, at least not so far as zic's usage is concerned.

Hmmm ... on closer inspection, though, it might not be that hard.
pgreadlink is already using a fixed-length buffer (with only enough
room for MAX_PATH WCHARs) for the input of WideCharToMultiByte.  So
it could use a fixed-length buffer of say 4 * MAX_PATH bytes for the
output, and then transfer just the appropriate amount of data to the
caller's buffer.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Possible memory corruption (src/timezone/zic.c b/src/timezone/zic.c)
Next
From: Alvaro Herrera
Date:
Subject: Re: compute_query_id and pg_stat_statements