Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH 2/5] Make relpathbackend return a statically result instead of palloc()'ing it - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH 2/5] Make relpathbackend return a statically result instead of palloc()'ing it
Date
Msg-id 21944.1357673294@sss.pgh.pa.us
Whole thread Raw
In response to [PATCH 2/5] Make relpathbackend return a statically result instead of palloc()'ing it  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: [PATCH 2/5] Make relpathbackend return a statically result instead of palloc()'ing it
List pgsql-hackers
Tree view 
Andres Freund <andres@2ndquadrant.com> writes:
maxpg> From: Andres Freund <andres@anarazel.de>
> relpathbackend() (via some of its wrappers) is used in *_desc routines which we
> want to be useable without a backend environment arround.

I'm 100% unimpressed with making relpathbackend return a pointer to a
static buffer.  Who's to say whether that won't create bugs due to
overlapping usages?

> Change signature to return a 'const char *' to make misuse easier to
> detect.

That seems to create way more churn than is necessary, and it's wrong
anyway if the result is palloc'd.
        regards, tom lane

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [PATCH] xlogreader-v4
Next
From: Andres Freund
Date:
Subject: Re: [PATCH 1/5] Centralize Assert* macros into c.h so its common between backend/frontend