Postgres Pro
Downloads
Home   >   mailing lists

Re: Unnecessary global variable declared in xlog.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Unnecessary global variable declared in xlog.c
Date
Msg-id 2193235.1637046534@sss.pgh.pa.us
Whole thread Raw
In response to Re: Unnecessary global variable declared in xlog.c  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Unnecessary global variable declared in xlog.c
List pgsql-hackers
Tree view 
Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Nov 16, 2021 at 11:17:27AM +0530, Amul Sul wrote:
>> The attached patch moves the "LastRec" variable declaration inside
>> StartupXLOG() where it is supposed to be.

> Yes, reading through the code, your suggestion makes sense.  I'll
> double-check and apply if there are no objections.

I think LastRec was originally referenced by multiple functions
in xlog.c.  But it does look like it could be a local now.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Skipping logical replication transactions on subscriber side
Next
From: Masahiko Sawada
Date:
Subject: Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN