Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH 1/5] Centralize Assert* macros into c.h so its common between backend/frontend - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH 1/5] Centralize Assert* macros into c.h so its common between backend/frontend
Date
Msg-id 21859.1357673106@sss.pgh.pa.us
Whole thread Raw
In response to [PATCH 1/5] Centralize Assert* macros into c.h so its common between backend/frontend  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: [PATCH 1/5] Centralize Assert* macros into c.h so its common between backend/frontend
List pgsql-hackers
Tree view 
Andres Freund <andres@2ndquadrant.com> writes:
> From: Andres Freund <andres@anarazel.de>
> c.h already had parts of the assert support (StaticAssert*) and its the shared
> file between postgres.h and postgres_fe.h. This makes it easier to build
> frontend programs which have to do the hack.

This patch seems unnecessary given that we already put a version of Assert()
into postgres_fe.h.  I don't think that moving the two different
definitions into an #if block in one file is an improvement.  If that
were an improvement, we might as well move everything in both postgres.h
and postgres_fe.h into c.h with a pile of #ifs.
        regards, tom lane

pgsql-hackers by date:

Previous
From: Thom Brown
Date:
Subject: Re: [PATCH] xlogreader-v4
Next
From: Andres Freund
Date:
Subject: Re: [PATCH] xlogreader-v4