Re: pg_dump: Remove obsolete trigger support - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_dump: Remove obsolete trigger support
Date
Msg-id 2184267.1704814062@sss.pgh.pa.us
Whole thread Raw
In response to pg_dump: Remove obsolete trigger support  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: pg_dump: Remove obsolete trigger support
Re: pg_dump: Remove obsolete trigger support
List pgsql-hackers
Peter Eisentraut <peter@eisentraut.org> writes:
> In 30e7c175b81, support for pre-9.2 servers was removed from pg_dump. 
> But I found that a lot of dead code was left for supporting dumping 
> triggers from those old versions, presumably because that code was not 
> behind straightforward versioned "if" branches.  This patch removes the 
> rest of the unneeded code.

Hm, you're right, we can depend on pg_get_triggerdef in all cases now.
However, the patch looks a little incomplete: you did not remove
fetching of all of the now-unneeded values from the SQL queries.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Ants Aasma
Date:
Subject: Re: add AVX2 support to simd.h
Next
From: Robert Haas
Date:
Subject: Re: the s_lock_stuck on perform_spin_delay