I found that the perl test modules are not installed. See attached
patch to correct this.
To the patches:
4e15ee0e24 Don't hardcode tmp_check/ as test directory for tap tests
1a3169bc3f Split TESTDIR into TESTLOGDIR and TESTDATADIR
It's a bit weird that the first patch changes the meaning of TESTDIR
and the second patch removes it. Maybe these patches should be
squashed together?
96d1d0a0cf meson: prereq: Extend gendef.pl in preparation for meson
ok
581721fa99 meson: prereq: Add src/tools/gen_export.pl
Still wondering about the whitespace changes I reported recently, but
that can also be fine-tuned later.
4245cc888e meson: prereq: Refactor PG_TEST_EXTRA logic in autoconf build
ok
3afe803e0f meson: prereq: Fix warning compat_informix/rnull.pgc with msvc
ok
ae7733f46c meson: prereq: Move darwin sysroot determination into
separate file
ok
a1fb97a81b meson: Add meson based buildsystem
I'm not a fan of all this business to protect the two build systems
from each other. I don't like the build process touching a file under
version control every time. How necessary is this? What happens
otherwise?
conversion_helpers.txt: should probably be removed now.
doc/src/sgml/resolv.xsl: I don't understand what this is doing. Maybe
at least add a comment in the file.
src/common/unicode/meson.build: The comment at the top of the file
should be moved next to the files it is describing (similar to how it
is in the makefile). I don't see CLDR_VERSION set anywhere. Is that
part implemented?
src/port/win32ver.rc.in: This is redundant with src/port/win32ver.rc.
(Note that the latter is also used as an input file for text
substitution. So having another file named *.in next to it would be
super confusing.)
src/tools/find_meson: Could use a brief comment what it does.
src/tools/pgflex: Could use a not-brief comment about what it does,
why it's needed. Also a comment where it's used. Also run this
through pycodestyle.
src/tools/rcgen: This is connected with the comment on win32ver.rc.in
above. We already have this equivalent code in
src/makefiles/Makefile.win32. Let's figure out a way to share this
code. (It could be a Perl script, which is already required on
Windows.) Also pycodestyle.
src/tools/testwrap: also documentation/comments/pycodestyle
cd193eb3e8 meson: ci: Build both with meson and as before
I haven't reviewed this one in detail. Maybe add a summary in the
commit message, like these are the new jobs, these are the changes to
existing jobs. It looks like there is more in there than just adding
a few meson jobs.
If the above are addressed, I think this will be just about at the
point where the above patches can be committed.
Everything past these patches I'm mentally postponing right now.
