Re: [BUGS] BUG #8335: trim() un-document behaviour - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [BUGS] BUG #8335: trim() un-document behaviour
Date
Msg-id 21732.1376330108@sss.pgh.pa.us
Whole thread Raw
In response to Re: [BUGS] BUG #8335: trim() un-document behaviour  (Bruce Momjian <bruce@momjian.us>)
Responses Re: [BUGS] BUG #8335: trim() un-document behaviour  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> Based on my research, I am now proposing a new, attached patch which
> eliminates comma in all places in TRIM,

This will break even more stuff than the last patch, ie, every single
stored rule or view that contains a TRIM function.  You can *not*
eliminate, or mess with, the expr_list production, because that's what
dumping of these function calls relies on.

It's easily a dozen years too late to change this, Bruce.  Please just
think about documenting the underlying functions, if you feel a need
to do anything here.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: pg_basebackup vs. Windows and tablespaces
Next
From: Tom Lane
Date:
Subject: Re: killing pg_dump leaves backend process