> The patch moves the atexit setting up, as you suggested, but only does
> that when pg_ctl succeeds (we know we started the server),
Yes, of course!
> PG 9.1+ will allow pg_ctl -w start to succeed even if there are
> permissions problems; earlier versions will not and will keep the
> server running --- the user will have to stop the server after
> pg_upgrade says it is running.
This makes it a complex, really.. We may not easily make the
stop_postmaster resistant to non-running server. Thus your solution must
be good enough.
> I am not going to backpatch this beyond 9.3 as it is risky code. I have
> improved the comments in this area.
Agree, it is OK for me — thanks for your work.
Pavel
