Re: pgsql-server/src/backend commands/typecmds.c e ... - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql-server/src/backend commands/typecmds.c e ...
Date
Msg-id 217.1063174190@sss.pgh.pa.us
Whole thread Raw
In response to pgsql-server/src/backend commands/typecmds.c e ...  (petere@svr1.postgresql.org (Peter Eisentraut - PostgreSQL))
Responses Re: pgsql-server/src/backend commands/typecmds.c e ...  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-committers
petere@svr1.postgresql.org (Peter Eisentraut - PostgreSQL) writes:
> Modified files:
>     src/backend/commands: typecmds.c
>     src/backend/executor: execQual.c functions.c
>     src/backend/parser: gram.y
>     src/backend/tcop: utility.c
>     src/backend/utils/adt: acl.c array_userfuncs.c pgstatfuncs.c
>                            ri_triggers.c ruleutils.c sets.c varbit.c
>     src/backend/utils/fmgr: funcapi.c

> Log message:
>     Some "feature not supported" errors are better syntax errors, because the
>     feature they complain about isn't a feature or cannot be implemented without
>     definitional changes.

I looked over this change, and right offhand I don't agree with any of
it.  None of the errors are "syntax" errors (if they were, gram.y would
have barfed) and the textual error message changes generally seem to be
trending in a less not more helpful direction.  What is your rationale
for this, please?

            regards, tom lane

pgsql-committers by date:

Previous
From: momjian@svr1.postgresql.org (Bruce Momjian)
Date:
Subject: pgsql-server/src Makefile.shlib
Next
From: Tom Lane
Date:
Subject: Re: pgsql-server/src backend/bootstrap/Tag: backen ...