Re: Conflict between regression tests namespace & transactions due to recent changes - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Conflict between regression tests namespace & transactions due to recent changes
Date
Msg-id 2165312.1684167368@sss.pgh.pa.us
Whole thread Raw
In response to Conflict between regression tests namespace & transactions due to recent changes  (Marina Polyakova <m.polyakova@postgrespro.ru>)
Responses Re: Conflict between regression tests namespace & transactions due to recent changes
Re: Conflict between regression tests namespace & transactions due to recent changes
List pgsql-hackers
Marina Polyakova <m.polyakova@postgrespro.ru> writes:
> IIUC the conflict was caused by

> +SET search_path to public, test_ns_schema_1;
> +CREATE SCHEMA test_ns_schema_2
> +       CREATE VIEW abc_view AS SELECT a FROM abc;

> because the parallel regression test transactions had already created 
> the table abc and was trying to drop it.

Hmm.  I'd actually fix the blame on transactions.sql here.  Creating
a table named as generically as "abc" is horribly bad practice in
a set of concurrent tests.  namespace.sql is arguably okay, since
it's creating that table name in a private schema.

I'd be inclined to fix this by doing s/abc/something-else/g in
transactions.sql.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Marina Polyakova
Date:
Subject: Conflict between regression tests namespace & transactions due to recent changes
Next
From: Bruce Momjian
Date:
Subject: Re: cutting down the TODO list thread