Re: headerscheck warnings with late-model gcc - Mailing list pgsql-hackers

From Tom Lane
Subject Re: headerscheck warnings with late-model gcc
Date
Msg-id 2159707.1756478859@sss.pgh.pa.us
Whole thread Raw
In response to Re: headerscheck warnings with late-model gcc  (Peter Eisentraut <peter@eisentraut.org>)
List pgsql-hackers
Peter Eisentraut <peter@eisentraut.org> writes:
> On 07.08.25 16:58, Tom Lane wrote:
>> 0004: I prefer the solution I exhibited yesterday, ie add
>> externs to those headers.

> That solution seems fine, too.

Great.

> This comment should be clarified:
> +    # This redundant extern declaration is needed to silence headerscheck
> +    # warnings with some gcc versions.
> You could just write
> # silence -Wmissing-variable-declarations
> which also appears elsewhere in the code.

I compromised on writing "redundant declaration to silence
-Wmissing-variable-declarations", and pushed it.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: make LWLockCounter a global variable
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] Generate random dates/times in a specified range