> > With the current implementation, I don't beleive it will make a
> difference -
> > I don't think that any part of the Winsock system is
> actually hidden if
> you
> > ask for a lower version. But it is _permitted_ by the
> specification that
> the
> > DLL can hide parts that belong to a higher version than the
> one requested.
> >
> > So I'm not 100% sure... Does anybody have access to a
> Winsock?@that
> actually
> > hides some details when you ask for the wrong version?
> >
>
> By the specs there may be the DLL that doesn't support lower versions.
> In that case my code doesn't work well.
> But we can delay to call WSAStartup() after the first socket
> call in LIBPQ.
> My example code in fe-connect.c is such as follows.
This looks like a great way to do it :-)
> hp = gethostbyname(conn->pghost);
> #ifdef WIN32
> if ((hp == NULL) && (GetLastError() == WSANOTINITIALISED))
> {
> WSADATA wsaData;
> if (WSAStartup(MAKEWORD(1,1),&wsaData))
> {
> fprintf(stderr, "Failed to start
> winsock: %i\n", WSAGetLastError());
> exit(1);
This is not the way to do it, though - what if it's a gui program.
Should instead be, like the other error handling:
sprintf(conn->errorMessage,
"connectDB() -- Failed to start
winsock: %i\n",
WSAGetLstError());
goto connect_errReturn;
> }
> ....
> ???? for WSACleanup() ????
> ....
Yes, this is the problem. Perhaps set a global flag in the DLL that is set
if we have ever called WSAStartup() from the DLL. Then we can check in
DllMain() at process detachment if we have to close the winsock?
Will you write up a patch or should I?
//Magnus
