Re: Crash on attempt to connect to nonstarted server - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Crash on attempt to connect to nonstarted server
Date
Msg-id 21548.1292513944@sss.pgh.pa.us
Whole thread Raw
In response to Crash on attempt to connect to nonstarted server  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Crash on attempt to connect to nonstarted server  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> I get a crash on win32 when connecting to a server that's not started.
> In fe-connect.c, we have:

>         display_host_addr = (conn->pghostaddr == NULL) &&
>             (strcmp(conn->pghost, host_addr) != 0);

> In my case, conn->pghost is NULL at this point, as is
> conn->pghostaddr. Thus, it crashes in strcmp().

[ scratches head... ]  I seem to remember having decided that patch was
OK because what was there before already assumed conn->pghost would be
set.  Under exactly what conditions could we get this far with neither
field being set?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: Question regarding psql or libpq
Next
From: Tom Lane
Date:
Subject: Re: Question regarding psql or libpq