Re: pg_type_d.h location incorrect - Mailing list pgsql-docs

From Tom Lane
Subject Re: pg_type_d.h location incorrect
Date
Msg-id 2150497.1622313061@sss.pgh.pa.us
Whole thread Raw
In response to RE: pg_type_d.h location incorrect  ("tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>)
List pgsql-docs
"tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com> writes:
> On Thursday, May 27, 2021 11:27 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote
>> No ... "patch -p1 <~/improve-pgservice-docs.patch" works fine for me.

> Oh, never tried "patch -p1" command before but it worked. Thanks!!
> BTW, here is my previous operation to apply your patch(failed, which is strange IMO)

> $ git apply --3way improve-pgservice-docs.patch

Yeah, "git apply" is extremely picky.  I'm not sure we've ever figured out
all the reasons why it sometimes doesn't work.  Good old "patch" pretty
much always works though.

> Attached a patch to combine the above fix in your patch.
> Also fixed a typo in install-windows.sgml.
> Also fixed pgbuffercache.sgml as Michael commented at [1].

LGTM, pushed with one minor additional tweak.

            regards, tom lane



pgsql-docs by date:

Previous
From: "tanghy.fnst@fujitsu.com"
Date:
Subject: RE: pg_type_d.h location incorrect
Next
From: Emre Hasegeli
Date:
Subject: Note that ALTER TABLE cannot alter generated stored columns