Request a Demo
Home   >   mailing lists

Re: Dead code in logical decoding of speculative insertions - Mailing list pgsql-hackers

From Antonin Houska
Subject Re: Dead code in logical decoding of speculative insertions
Date
Msg-id 21434.1772790818@localhost
Whole thread Raw
In response to Re: Dead code in logical decoding of speculative insertions  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
Tree view 
Amit Kapila <amit.kapila16@gmail.com> wrote:

> On Thu, Mar 5, 2026 at 2:59 PM Antonin Houska <ah@cybertec.at> wrote:
> >
> > Since commit 4daa140a2f50 adds the INTERNAL_SPEC_ABORT change, I think it's no
> > longer necessary to care about "pending speculations" at the time we receive
> > the next INTERNAL_SPEC_INSERT change.
> >
>
> Right, I also think so. Did you find it via code review or some other way?

Yes, I noticed that via code review, while investigating a crash:

[1] https://www.postgresql.org/message-id/CAFC%2Bb6o2yzA80YmfEhmMO9puN8qvGRvr-15BBLn3UmJxPfpr2w%40mail.gmail.com

--
Antonin Houska
Web: https://www.cybertec-postgresql.com

pgsql-hackers by date:

Previous
From: jian he
Date:
Subject: Re: Emitting JSON to file using COPY TO
Next
From: "Zhijie Hou (Fujitsu)"
Date:
Subject: RE: [PATCH] Support automatic sequence replication