Re: [BUGS] Crash with a CUBE query on 9.6 - Mailing list pgsql-bugs

From Tom Lane
Subject Re: [BUGS] Crash with a CUBE query on 9.6
Date
Msg-id 21373.1482182544@sss.pgh.pa.us
Whole thread Raw
In response to Re: [BUGS] Crash with a CUBE query on 9.6  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: [BUGS] Crash with a CUBE query on 9.6
List pgsql-bugs
Heikki Linnakangas <hlinnaka@iki.fi> writes:
> On 12/19/2016 09:37 PM, Tom Lane wrote:
>> Probably, the loop in finalize_aggregates needs to be split into two,
>> one over the pertrans states and then a second one over the peragg states.
>> But this code has been hacked up enough since I last looked at it that
>> I'm hesitant to try to fix it myself.

> Yes, that seems straightforward. I came up with the attached. Will 
> commit tomorrow, barring objections.

Code patch looks reasonable, but I do not get a crash on the proposed test
case with current code.  I suspect that integer avg() and sum() don't
actually share transstates, making the test case a bit off-point.

            regards, tom lane


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs

pgsql-bugs by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: [BUGS] Crash with a CUBE query on 9.6
Next
From: Keith Fiske
Date:
Subject: Re: [BUGS] 9.6rc1 Background worker starting multiple times