Re: btree_gist macaddr valgrind woes - Mailing list pgsql-hackers

From Tom Lane
Subject Re: btree_gist macaddr valgrind woes
Date
Msg-id 21358.1400268712@sss.pgh.pa.us
Whole thread Raw
In response to Re: btree_gist macaddr valgrind woes  (Heikki Linnakangas <hlinnakangas@vmware.com>)
Responses Re: btree_gist macaddr valgrind woes  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
Heikki Linnakangas <hlinnakangas@vmware.com> writes:
> On 05/16/2014 06:43 PM, Tom Lane wrote:
>> Dunno what's the problem for the varlena types, but that's a completely
>> separate code path.

> It seems to be a similar issue to what I fixed in the bit type earlier. 
> When the lower+upper keys are stored as one varlen Datum, the padding 
> bytes between them are not zeroed. With these datatypes (i.e. not 
> varbit) it doesn't lead to any real errors, however, because the padding 
> bytes are never read. Valgrind is just complaining that we're storing 
> uninitialized data on disk, even though it's never looked at.

Yeah, I came to the same conclusions.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: btree_gist macaddr valgrind woes
Next
From: Tom Lane
Date:
Subject: Re: btree_gist macaddr valgrind woes