Re: generating bootstrap entries for array types - Mailing list pgsql-hackers

From Tom Lane
Subject Re: generating bootstrap entries for array types
Date
Msg-id 2120.1537471077@sss.pgh.pa.us
Whole thread Raw
In response to Re: generating bootstrap entries for array types  (ilmari@ilmari.org (Dagfinn Ilmari Mannsåker))
Responses Re: generating bootstrap entries for array types  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: generating bootstrap entries for array types  (John Naylor <jcnaylor@gmail.com>)
List pgsql-hackers
ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
> Tom Lane <tgl@sss.pgh.pa.us> writes:
>> I'm inclined to think the right way is to do the expansion always,
>> and teach reformat_dat_file.pl to drop autogenerated array types
>> on the way out, making this work more like the existing facilities
>> for default/computed fields.
>> 
>> The easiest way to make that happen seems to be to invent another, purely
>> internal metadata field, along the lines of "is_autogenerated_entry".
>> Fooling with that now ...

> Something like this, on top of the v2 patch?

Yeah, that's pretty close to what I came up with, except that I thought
it'd be good if "reformat_dat_file.pl --full-tuples" would print
autogenerated entries; seems useful for debug purposes if nothing else.
So that requires also teaching ParseData to ignore autogenerated entries
on read-in, else you end up with duplicates.

I did some other minor hacking (mostly, fixing the documentation)
and pushed it.

            regards, tom lane


pgsql-hackers by date:

Previous
From: John Naylor
Date:
Subject: Re: generating bootstrap entries for array types
Next
From: Tom Lane
Date:
Subject: Re: generating bootstrap entries for array types