Re: [PATCH] hs_standby_disallowed test fix - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: [PATCH] hs_standby_disallowed test fix
Date
Msg-id 2116f5f9-24b6-2750-7698-f887182c5991@oss.nttdata.com
Whole thread Raw
In response to [PATCH] hs_standby_disallowed test fix  (Michail Nikolaev <michail.nikolaev@gmail.com>)
Responses Re: [PATCH] hs_standby_disallowed test fix
Re: [PATCH] hs_standby_disallowed test fix
List pgsql-hackers

On 2020/05/12 8:03, Michail Nikolaev wrote:
> Hello.
> 
> There is a recent commit about changes in way read-only commands are
> prevented to be executed [1].
> 
> It seems like hs_standby_disallowed test is broken now.
> 
> So, a simple patch to fix the test is attached.

Thanks for the report and patch! LGTM.

I just wonder why standbycheck regression test doesn't run by default
in buildfarm. Which caused us not to notice this issue long time. Maybe
because it's difficult to set up hot-standby environment in the
regression test? If so, we might need to merge standbycheck test into
TAP tests for recovery.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



pgsql-hackers by date:

Previous
From: Tatsuro Yamada
Date:
Subject: Re: PG 13 release notes, first draft
Next
From: Amit Kapila
Date:
Subject: Re: PG 13 release notes, first draft