Re: pgcrypto: Remove explicit hex encoding/decoding from tests - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgcrypto: Remove explicit hex encoding/decoding from tests
Date
Msg-id 2116430.1638469845@sss.pgh.pa.us
Whole thread Raw
In response to pgcrypto: Remove explicit hex encoding/decoding from tests  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-hackers
Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> pgcrypto tests use encode() and decode() calls to convert to/from hex 
> encoding.  This was from before the hex format was available in bytea. 
> Now we can remove the extra explicit encoding/decoding calls and rely on 
> the default output format.

Generally +1, but I see you removed some instances of

--- ensure consistent test output regardless of the default bytea format
-SET bytea_output TO escape;

I think that the principle still applies that this should work regardless
of the installation's default bytea format, so I'd recommend putting

-- ensure consistent test output regardless of the default bytea format
SET bytea_output TO hex;

at the top of each file instead.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Replace uses of deprecated Python module distutils.sysconfig
Next
From: Alexander Lakhin
Date:
Subject: Re: Windows: Wrong error message at connection termination