Re: Visual Studio 2005, C-language function - avoiding hacks? - Mailing list pgsql-hackers

Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp> writes:
> I'd like to propose to define PGALWAYSEXPORT macro:
>     #ifdef WIN32
>     #define PGALWAYSEXPORT  __declspec (dllexport)
>     #endif
> and modify PG_MODULE_MAGIC and PG_FUNCTION_INFO_V1 to use it
> instead of PGDLLEXPORT.

This seems like change for the sake of change.  The existing mechanism
works (as demonstrated by the fact that the contrib modules work on
Windows).  I don't think we should invent a new mechanism that won't be
backwards-compatible.
        regards, tom lane