Re: auto_explain contrib moudle - Mailing list pgsql-hackers

From Tom Lane
Subject Re: auto_explain contrib moudle
Date
Msg-id 20945.1226696141@sss.pgh.pa.us
Whole thread Raw
In response to Re: auto_explain contrib moudle  (Jeff Davis <pgsql@j-davis.com>)
Responses Re: auto_explain contrib moudle  (ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>)
List pgsql-hackers
Jeff Davis <pgsql@j-davis.com> writes:
> On Thu, 2008-11-13 at 14:31 -0500, Tom Lane wrote:
>> This patch seems to contain a subset of the "contrib infrastructure"
>> patch that's listed separately on the commitfest page.  While I have
>> no strong objection to what's here, I'm wondering what sort of process
>> we want to follow.  Is the infrastructure stuff getting separately
>> reviewed or not?

> I can review it, but not until this weekend. It looks like someone
> already added me to the list of reviewers on that patch. I'm not sure if
> Matthew Wetmore has already started reviewing it or not.

Now that I look closer, the "contrib infrastructure" item is just a
combination of the auto_explain and pg_stat_statements items, and I
guess the reason you and Matthew were shown as reviewers was that
you'd each been assigned one of those two items.  As far as I can see
this is just confusing and duplicative.  I've removed the
"infrastructure" item from the commitfest page; I think we can
proceed with the two other items separately.  If there's any conflict
in the two patches we can resolve it after the first one gets applied.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Assorted contrib infrastructures patch
Next
From: Tom Lane
Date:
Subject: Re: contrib/pg_stat_statements