Re: [PATCHES] Dbsize backend integration - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCHES] Dbsize backend integration
Date
Msg-id 20929.1120617516@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCHES] Dbsize backend integration  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: [PATCHES] Dbsize backend integration
List pgsql-hackers
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Tom Lane wrote:
>> I could live with that.  Or "pg_total_relation_size".

> The problem with "total", to me, is that it already is the total size of
> the heap/index/toast.  Complete has the idea of adding additional
> pieces, which I think fits best.

[ shrug ]  I don't care --- if you do, then do that.

I finally realized exactly what was bugging me about "dbfile_size": it
seems to imply that we are measuring the size of one *file*, which is
under no circumstance the definition of any of these functions (see
file splitting behavior for relations exceeding 1GB).

pg_relation_size plus pg_complete_relation_size is fine.  Ship it...

            regards, tom lane

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: timezone changes break windows and cygwin
Next
From: Tom Lane
Date:
Subject: Re: oids vs composite types, in cvs head