Re: BUG #6692: Potential Bug in equalfuncs.c - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #6692: Potential Bug in equalfuncs.c
Date
Msg-id 20918.1339864302@sss.pgh.pa.us
Whole thread Raw
In response to BUG #6692: Potential Bug in equalfuncs.c  (msrbugzilla@gmail.com)
List pgsql-bugs
msrbugzilla@gmail.com writes:
> I observed a code clone in the following files. The function
> "COMPARE_LOCATION_FIELD" is called in some functions and missed in other
> functions. I wonder if this is a bug. Hope it helps.

Well, COMPARE_LOCATION_FIELD() is a no-op anyway, but for
documentation's sake it should be called in the comparison function for
every node type that has a token location field (some do, some don't).
So far as I can see, it is called where it should be.  Did you observe a
place where it is not, and if so where?

            regards, tom lane

pgsql-bugs by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: pg_upgrade fails with missing FTS resources
Next
From: Tom Lane
Date:
Subject: Re: BUG #6693: Potential Bug in rewriteManip.c