Re: Add more sanity checks around callers of changeDependencyFor() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Add more sanity checks around callers of changeDependencyFor()
Date
Msg-id 2091513.1689000684@sss.pgh.pa.us
Whole thread Raw
In response to Re: Add more sanity checks around callers of changeDependencyFor()  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Add more sanity checks around callers of changeDependencyFor()
List pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> On Thu, Jul 06, 2023 at 10:09:20AM -0700, Andres Freund wrote:
>> I also don't think pg_dump will dump the changed schema, which means a
>> dump/restore leads to a different schema - IMO something to avoid.

> Yes, you're right here.  The function dumped is restored in the same
> schema as the extension.

Actually, I think the given example demonstrates pilot error rather
than a bug.  The user has altered properties of an extension member
object locally within the database, but has not changed the extension's
installation script to match.  The fact that after restore, the object
does again match the script is intended behavior.  We've made some
exceptions to that rule for permissions, but not anything else.
I don't see a reason to consider the objects' schema assignments
differently from other properties for this purpose.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: remaining sql/json patches
Next
From: Alvaro Herrera
Date:
Subject: Re: remaining sql/json patches