Re: Re: [COMMITTERS] pgsql: Add some isolation tests for deadlock detection and resolution. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Re: [COMMITTERS] pgsql: Add some isolation tests for deadlock detection and resolution.
Date
Msg-id 20895.1455376574@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Add some isolation tests for deadlock detection and resolution.  (Greg Stark <stark@mit.edu>)
List pgsql-hackers
Greg Stark <stark@mit.edu> writes:
> The tests worked fine on faster build animals, right? And the clobber
> animals are much much slower.... So it seems perfectly sensible that their
> deadlock timeout would just have to be much much higher to have the same
> behaviour. I see nothing wrong in just setting deadlock timeout to a minute
> or more on these machines.

We don't have a way to make the isolation tests change behavior depending
on how the backend is compiled.  So the only actually available fix is to
make that test take "a minute or more" for *everybody*.

Aside from that, it's just disturbing that these tests aren't
deterministic regardless of machine speed.  We don't seem to have a
way around that right now, but I wish we did.
        regards, tom lane



pgsql-hackers by date:

Previous
From: "Joshua D. Drake"
Date:
Subject: Re: Defaults for replication/backup
Next
From: Andres Freund
Date:
Subject: Re: Defaults for replication/backup