Re: [PATCH] avoid double scanning in function byteain - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] avoid double scanning in function byteain
Date
Msg-id 2087323.1752871688@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] avoid double scanning in function byteain  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
I wrote:
> I'm inclined to accept 0001, reject 0002, and move on.  This doesn't
> seem like an area that's worth a huge amount of discussion.

Done that way.  I made a couple more cosmetic changes and added
test cases for the double-backslash code path (which hadn't been
covered in byteaout either, I see now).

BTW, in my hands the microbenchmark that Stepan suggested shows the
committed version to be about 40% faster than before for long input.
So apparently the StringInfo-ification suggested in 0002 gave back
just about all the performance gain from 0001.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Adding basic NUMA awareness
Next
From: Andres Freund
Date:
Subject: Re: index prefetching