Re: [HACKERS] pgsql: Fix compiler warnings on 64-bit boxes: - Mailing list pgsql-committers

From Tom Lane
Subject Re: [HACKERS] pgsql: Fix compiler warnings on 64-bit boxes:
Date
Msg-id 20830.1157561707@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] pgsql: Fix compiler warnings on 64-bit  (Teodor Sigaev <teodor@sigaev.ru>)
List pgsql-committers
Teodor Sigaev <teodor@sigaev.ru> writes:
>> ereport(...errmsg("trouble at offset " UINT64_FORMAT, bigintvar));

> One more solution: add format code %D to expand_fmt_string() which should be
> expanded to usual %d on 32-bit architecture and to UINT64_FORMAT on 64-bit.

Not very workable unless you can figure out how to teach gcc what it means...
else we lose compiler checking that the corresponding argument matches,
which'd be even more important than usual with a machine-dependent
format code.

            regards, tom lane

pgsql-committers by date:

Previous
From: Teodor Sigaev
Date:
Subject: Re: [HACKERS] pgsql: Fix compiler warnings on 64-bit
Next
From: h-saito@pgfoundry.org (User H-saito)
Date:
Subject: npgsql - Npgsql: Ooops,sorry..