Re: pgsql: Add a note about another issue that needs to be considered before - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Add a note about another issue that needs to be considered before
Date
Msg-id 20806.1194279050@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Add a note about another issue that needs to be considered before  (Gregory Stark <stark@enterprisedb.com>)
Responses Re: pgsql: Add a note about another issue that needs to be considered before  (Gregory Stark <stark@enterprisedb.com>)
List pgsql-committers
Gregory Stark <stark@enterprisedb.com> writes:
> FWIW I found another issue with this variable when I was experimenting with
> small block sizes. If you set the target <= the tuple header the toaster
> breaks. This is because it's doing unsigned arithmetic (Size is unsigned). I
> think the right solution is just to change it to use plain int32 arithmetic
> everywhere.

Somehow I can't get excited about that.  If we ever do open things up to
allow user control of the target, we'd certainly constrain it to a sane
range.

            regards, tom lane

pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: pgsql: Document txid functions.
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Document txid functions.