Re: [HACKERS] outfuncs.c utility statement support - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [HACKERS] outfuncs.c utility statement support
Date
Msg-id 2071d3c8-3520-4f02-d1a6-bceb933f8779@2ndquadrant.com
Whole thread Raw
In response to [HACKERS] outfuncs.c utility statement support  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: [HACKERS] outfuncs.c utility statement support  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Re: [HACKERS] outfuncs.c utility statement support  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 6/13/17 11:25, Peter Eisentraut wrote:
> Running with --debug-print-parse=on, executing
> 
> create table test1 (a int, b text);
> 
> gives output that is truncated somewhere in the middle (possibly a null
> byte)

So this seems to be a pretty basic bug.  Some node fields of type char
may be zero, and so printing them as a zero byte just truncates the
whole output string.  This could be fixed by printing chars like strings
with the full escaping mechanism.  See attached patch.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Detection of IPC::Run presence in SSL TAP tests
Next
From: Amit Langote
Date:
Subject: Re: [HACKERS] A bug in mapping attributes in ATExecAttachPartition()