Re: Case Conversion Fix for MB Chars - Mailing list pgsql-patches

From Tom Lane
Subject Re: Case Conversion Fix for MB Chars
Date
Msg-id 2071.1133108975@sss.pgh.pa.us
Whole thread Raw
In response to Re: Case Conversion Fix for MB Chars  (Volkan YAZICI <volkan.yazici@gmail.com>)
Responses Re: Case Conversion Fix for MB Chars
List pgsql-patches
Volkan YAZICI <volkan.yazici@gmail.com> writes:
> On 11/27/05, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> The really fundamental problem is that tolower/toupper don't work
>> on wchar_t.

> Yes, indeed. I agree with you to find a proper solution for character
> set handling. But, IMHO, it's better to have a-patchy working system
> instead of a not working one.

But you just agreed that it doesn't work.

It might be that there are degrees of not-working-ness here, but before
adopting a partial solution I would like to see some reasoning why it
won't make things worse for other people.  I think that what you are
proposing could lead to arbitrarily bad behavior (up to and including
server crashes) depending on what libc's toupper/tolower functions are
coded to do with out-of-range inputs.  Exactly what cases have you
tried, and on what platforms?

            regards, tom lane

pgsql-patches by date:

Previous
From: Volkan YAZICI
Date:
Subject: Re: Case Conversion Fix for MB Chars
Next
From: Martijn van Oosterhout
Date:
Subject: [PATCH] Reduce dependancies of postmaster (without --as-needed)