Re: A bug when use get_bit() function for a long bytea string - Mailing list pgsql-hackers

From Tom Lane
Subject Re: A bug when use get_bit() function for a long bytea string
Date
Msg-id 20650.1585336799@sss.pgh.pa.us
Whole thread Raw
In response to Re: A bug when use get_bit() function for a long bytea string  ("Daniel Verite" <daniel@manitou-mail.org>)
List pgsql-hackers
"Daniel Verite" <daniel@manitou-mail.org> writes:
> So aside from the integer overflow bug, isn't there the issue that the
> "offset" argument of get_bit() and set_bit() should have been an
> int8 in the first place?

Good point, but a fix for that wouldn't be back-patchable.

It does suggest that we should just make all the internal logic use int8
for these values (as the solution to the overflow issue), and then in
HEAD only, adjust the function signatures so that int8 can be passed in.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Sergei Kornilov
Date:
Subject: Re: Improve handling of parameter differences in physical replication
Next
From: Robert Haas
Date:
Subject: Re: backup manifests