Postgres Pro
Downloads
Home   >   mailing lists

Re: Strange path from pgarch_readyXlog() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Strange path from pgarch_readyXlog()
Date
Msg-id 2061330.1640811852@sss.pgh.pa.us
Whole thread Raw
In response to Re: Strange path from pgarch_readyXlog()  ("Bossart, Nathan" <bossartn@amazon.com>)
Responses Re: Strange path from pgarch_readyXlog()  ("Bossart, Nathan" <bossartn@amazon.com>)
List pgsql-hackers
Tree view 
"Bossart, Nathan" <bossartn@amazon.com> writes:
> I bet this was a simple mistake in beb4e9b.

> -static char arch_filenames[NUM_FILES_PER_DIRECTORY_SCAN][MAX_XFN_CHARS];
> +static char arch_filenames[NUM_FILES_PER_DIRECTORY_SCAN][MAX_XFN_CHARS + 1];

Hm, yeah, that looks like a pretty obvious bug.

While we're here, I wonder if we ought to get rid of the static-ness of
these arrays.  I realize that they're only eating a few kB, but they're
doing so in every postgres process, when they'll only be used in the
archiver.

            regards, tom lane

pgsql-hackers by date:

Previous
From: "Bossart, Nathan"
Date:
Subject: Re: Strange path from pgarch_readyXlog()
Next
From: SATYANARAYANA NARLAPURAM
Date:
Subject: Logging replication state changes