Re: Should we remove -Wdeclaration-after-statement? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Should we remove -Wdeclaration-after-statement?
Date
Msg-id 2053130.1706566163@sss.pgh.pa.us
Whole thread Raw
In response to Re: Should we remove -Wdeclaration-after-statement?  (Andres Freund <andres@anarazel.de>)
Responses Re: Should we remove -Wdeclaration-after-statement?
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2024-01-29 15:01:06 -0500, Robert Haas wrote:
>> And it still baffles me why we allow everyone to pick their own system for
>> capitalizing identifiers out of a hat, without even insisting on consistency
>> from one end of the same identifier to the other.

> Yes. Please. I hate some capitalization/underscore styles, but I hate spending
> time feeling out which capitalization style I should use so much more.  Let's
> at least define some minimal naming guidelines for new code.

I'm for this for entirely-new code, but I think when adding code in
existing modules we're better off with the rule of "make it match
nearby code".  I admit it might be hard to draw a clear line between
the two cases, plus there might be local inconsistency already.
But let's try to avoid making local style inconsistencies worse.

            regards, tom lane



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Streaming read-ready sequential scan code
Next
From: David Rowley
Date:
Subject: Re: Optmize bitmapword macros calc (src/backend/nodes/bitmapset.c)