Re: [COMMITTERS] pgsql: Unify some tar functionality across different parts - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Unify some tar functionality across different parts
Date
Msg-id 20486.1357145072@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Unify some tar functionality across different parts  (Magnus Hagander <magnus@hagander.net>)
Responses Re: [COMMITTERS] pgsql: Unify some tar functionality across different parts  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> On Wed, Jan 2, 2013 at 5:36 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Why are these very tar-specific functions being declared in such a
>> globally visible spot as port.h?  That seems like a bad idea on its
>> face.  IMO stuff in port.h ought to be about as globally applicable
>> as, say, malloc().

> It's where we put most of the things from src/port in.

Might be time to revisit that, or perhaps better reconsider what we're
putting in src/port/.  The idea that anything that we want in both
frontend and backend is a porting issue seems a bit busted in itself.

> I take it you suggest moving it to a special say include/pgtar.h file?

Works for me.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Boszormenyi Zoltan
Date:
Subject: Re: Big disconnect_and_exit cleanup in pg_basebackup
Next
From: David Fetter
Date:
Subject: Re: Review of Row Level Security