Re: thread safety tests - Mailing list pgsql-hackers

From Tom Lane
Subject Re: thread safety tests
Date
Msg-id 20483.1086847902@sss.pgh.pa.us
Whole thread Raw
In response to Re: thread safety tests  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: thread safety tests  (Jan Wieck <JanWieck@Yahoo.com>)
List pgsql-hackers
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Are people OK with requiring PGUSER, $USER, $LOGNAME, or the username to
> be supplied by the connection string in libpq on platforms that want
> threads and don't have getpwuid_r() (Solaris, FreeBSD, etc.)?

AFAICS that was not what Jan was suggesting at all.  I don't like it
either --- changing the user-visible behavior based on whether we think
the platform is thread-safe or not is horrid.

What I understood Jan to be saying is that we should be willing to build
the most thread-safe approximation we can when --enable-thread-safety
is requested.  Don't bomb out if you don't have getpwuid_r, just give
a warning and then use getpwuid.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCHES] serverlog function (log_destination file)
Next
From: Andrew Dunstan
Date:
Subject: Re: [PATCHES] serverlog function (log_destination file)