Re: Trivial fixes for some IDENTIFICATION comment lines - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Trivial fixes for some IDENTIFICATION comment lines
Date
Msg-id 20470.1453136462@sss.pgh.pa.us
Whole thread Raw
In response to Re: Trivial fixes for some IDENTIFICATION comment lines  (Andres Freund <andres@anarazel.de>)
Responses Re: Trivial fixes for some IDENTIFICATION comment lines  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2016-01-18 12:52:06 +0100, Shulgin, Oleksandr wrote:
>> I've noticed that in src/backend/replication/logical/reorderbuffer.c, the
>> IDENTIFICATION comment line is incorrect:
>> 
>> * IDENTIFICATION
>> - *      src/backend/catalog/dropcmds.c
>> - *      src/backend/replication/logicalfuncs.c
>> - *      src/backend/replication/reorderbuffer.c
>> - *      src/backend/replication/snapbuild.c
>> - *      src/backend/storage/ipc/dsm.c
>> - *      src/backend/utils/cache/relfilenode.c
>> - *      src/backend/utils/cache/evtcache.c

> How about we simply drop them instead alltogether? This isn't exactly a
> seldomly made mistake, and they seem to actually contribute very little
> value?

Personally I think they're of some value.  Particularly with stuff like
Makefiles, which are otherwise confusingly similar.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Thom Brown
Date:
Subject: Re: Support for N synchronous standby servers - take 2
Next
From: Pavel Stehule
Date:
Subject: Re: Combining Aggregates