Re: enable fallthrough warnings on clang - Mailing list pgsql-hackers

From Tom Lane
Subject Re: enable fallthrough warnings on clang
Date
Msg-id 2042830.1775572527@sss.pgh.pa.us
Whole thread Raw
In response to Re: enable fallthrough warnings on clang  (Peter Eisentraut <peter@eisentraut.org>)
List pgsql-hackers
Peter Eisentraut <peter@eisentraut.org> writes:
> On 06.04.26 23:31, Tom Lane wrote:
>> BF member ayu is failing said test:
>> ...
>> I don't know if it's worth catering to this extremely old
>> clang version ...

> But AFAICT, clang 5 and older are completely broken in this regard, 
> because they react to the presence of [[clang::fallthrough]] with a 
> syntax error ("error: expected expression").  Not even clang's own 
> example code[0] works.

Hah, so we'd make it worse not better by adding
[[clang::fallthrough]].  Let's leave well enough alone then.

            regards, tom lane



pgsql-hackers by date:

Previous
From: SATYANARAYANA NARLAPURAM
Date:
Subject: Re: SQL:2011 Application Time Update & Delete
Next
From: Andrew Dunstan
Date:
Subject: Re: Add errdetail() with PID and UID about source of termination signal