Re: Wrong Results from SP-GiST with Collations - Mailing list pgsql-bugs

From Tom Lane
Subject Re: Wrong Results from SP-GiST with Collations
Date
Msg-id 20362.1523906934@sss.pgh.pa.us
Whole thread Raw
In response to Re: Wrong Results from SP-GiST with Collations  (Peter Geoghegan <pg@bowt.ie>)
Responses Re: Wrong Results from SP-GiST with Collations  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-bugs
Peter Geoghegan <pg@bowt.ie> writes:
> On Mon, Apr 16, 2018 at 11:51 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> and then the bit below about ...
>> needs to move into the "non-collation-aware" branch.

> Right. Alternatively, you could actually call varstr_cmp() within the
> "non-collation-aware" branch.

True.  This way saves a few cycles, but maybe it's not worth the extra
code.  I think the only case where you could really notice the difference
is for an equality search operator, which might end up doing a lot more
work in non-C collations (full-blown strcoll vs memcmp).

            regards, tom lane


pgsql-bugs by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Wrong Results from SP-GiST with Collations
Next
From: Tomas Vondra
Date:
Subject: Re: Standby corruption after master is restarted