Postgres Pro
Downloads
Home   >   mailing lists

Re: Reduce the memcpy call from SearchCatCache - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Reduce the memcpy call from SearchCatCache
Date
Msg-id 20298.1246909110@sss.pgh.pa.us
Whole thread Raw
In response to Reduce the memcpy call from SearchCatCache  (Atsushi Ogawa <a_ogawa@hi-ho.ne.jp>)
Responses Re: Reduce the memcpy call from SearchCatCache  (Atsushi Ogawa <a_ogawa@hi-ho.ne.jp>)
List pgsql-hackers
Tree view 
Atsushi Ogawa <a_ogawa@hi-ho.ne.jp> writes:
> Attached patch is reduce the memcpy calls from SearchCatCache
> and SearchCatCacheList. This patch directly uses cache->cc_skey
> in looking for hash table.

How much did you test this patch?  I'm fairly sure it will break things.
There are cases where cache lookups happen recursively.
        regards, tom lane

pgsql-hackers by date:

Previous
From: "David E. Wheeler"
Date:
Subject: Maintenance Policy?
Next
From: Peter Eisentraut
Date:
Subject: Small foreign key error message improvement