Re: Restore vacuum_delay_point() in GIN posting-tree leaf vacuum - Mailing list pgsql-hackers

From Paul Kim
Subject Re: Restore vacuum_delay_point() in GIN posting-tree leaf vacuum
Date
Msg-id 20260723022635.21756-1-mok03127@gmail.com
Whole thread
In response to Restore vacuum_delay_point() in GIN posting-tree leaf vacuum  (Paul Kim <mok03127@gmail.com>)
List pgsql-hackers
On 2026-07-22, Alexander Korotkov wrote:
> Please, check the patch attached.

Thanks, Alexander. The patch looks good to me -- it's the same change
I posted upthread, and the placement is right: the call sits after the
page has been unlocked and released, so no buffer content lock (nor any
other LWLock) is held across the delay, matching the sibling loops in
ginbulkdelete() and ginvacuumcleanup(). The added comment reads well.

One note for the back-branches, since it's marked Backpatch-through:
14: vacuum_delay_point() only gained its bool argument in e5b0b0ce150
(v18), so on 14-17 the call would need to be the no-argument
vacuum_delay_point().

--
Paul Kim



pgsql-hackers by date:

Previous
From: Jingtang Zhang
Date:
Subject: [PATCH] vacuum: stop using stream ring after failsafe
Next
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: [Bug] pg_upgrade could fail for non-superuser subscriptions using foreign servers